Skip to content

[testharness.js] functions registed via add_cleanup are not invoked if the test timed out #51507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hiikezoe opened this issue Mar 21, 2025 · 0 comments
Open

[testharness.js] functions registed via add_cleanup are not invoked if the test timed out #51507

hiikezoe opened this issue Mar 21, 2025 · 0 comments
Labels
infra testharness.js

Comments

@hiikezoe
Copy link
Contributor

I believe this issue was regressed by this change.

Basically those cleanup functions get called in Tests.prototype.complete, but when the test timed out, each test is marked as COMPLETE before invoking the complete function, thus in the complete function, these tests are filtered out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra testharness.js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsnedders @hiikezoe